Add workaround for lifetime intrinsics translation #20287
Draft
+71
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIRVReader has contained a bug for a long time, fixed in KhronosGroup/SPIRV-LLVM-Translator#3373 While the proper fix will be backported to earlier branches - it still will take a lot of time for adoption by LTS driver. Hence we have to add a W/A restoring old behaviour of lifetime intrinsics translation, inserting artificial bitcast to i8*. PR also includes update of a test from KhronosGroup/SPIRV-LLVM-Translator#3376 Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
MrSidims
commented
Oct 6, 2025
| SPIRVLifetimeStart *LTStart = static_cast<SPIRVLifetimeStart *>(BV); | ||
| IRBuilder<> Builder(BB); | ||
| auto *Var = transValue(LTStart->getObject(), F, BB); | ||
| Var = Var->stripPointerCasts(); |
There was a problem hiding this comment.
This strip bitcast is missing in intel/llvm, but it present in every other repository, both Khronos and downstream.
|
@intel/llvm-gatekeepers please consider merging |
Please don't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIRVReader has contained a bug for a long time, fixed in KhronosGroup/SPIRV-LLVM-Translator#3373
While the proper fix will be backported to earlier branches - it still will take a lot of time for adoption by LTS driver. Hence we have to add a W/A restoring old behaviour of lifetime intrinsics translation, inserting artificial bitcast to i8*.
PR also includes update of a test from
KhronosGroup/SPIRV-LLVM-Translator#3376